Repository navigation
docs(doc-review): daily review 2026-10-26 — RUM AI SRE query dock, per-application dashboards, error-location grouping - #1133
Merged
Conversation
added 3 commits
October 26, 2026 08:39
…r-application dashboards, error-location grouping
…link the EN RUM page at its section
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc Review — 2026-10-26
Mode: diff (since 2026-10-23T08:13:07Z — previous successful run; window end 2026-10-26T08:13Z)
Findings: 26 total — 3 high, 17 medium, 6 low · applied 19 · held 3 · skipped (already carried by an open PR / duplicate) 4
Repos scanned in the window: fc-event, fc-pgy, fc-rum, monit-webapi, fc-safari, flashduty-cli, go-flashduty, fc-foundation-app (+ fc-saas-rum, ai-sre-web submodules), flashduty-docs. Repos with zero commits in the window were skipped (fc-oncall, flashduty-app, fc-datasource, monit-edge, fc-statuspage, flashduty-mcp-server, terraform-provider-flashduty, flashduty-runner, fc-saas-web, fc-saas-monit, ai-assistant-web, meow-ui).
Changes
rum/explorer/data-query.mdxrum/explorer/data-query.mdxrum/explorer/data-query.mdxrum/analytics/custom-dashboards.mdxrum/analytics/custom-dashboards.mdxai-sre/sessions.mdxrum/analytics/custom-dashboards.mdxrum/explorer/data-query.mdxrum/explorer/data-query.mdxrum/analytics/custom-dashboards.mdxrum/error-tracking/error-aggregation.mdxai-sre/sessions.mdxon-call/incident/alert-management.mdxon-call/comparison/vs-pagerduty.mdxon-call/incident/search-view-incident.mdxdeveloper/cli.mdx--war-room-trigger/--war-room-channel-ids/--war-room-severitiesand the update toggles documenteddeveloper/go-sdk.mdxdeveloper/go-sdk.mdxExtra, outside the finding list: the 2026-10-19 changelog entry still described the per-panel application /
$appmodel that this window removed — that clause now carries a one-line correction pointing at the new rule (zh + en).Review checklist
Validation run in this PR (22 files, zh + en each):
mint broken-links:success no broken links found in the files that parsed,skipped 36 file(s)— the same 36 MDX parse errors that a cleanorigin/mainproduces (compared file-by-file with a worktree oforigin/main, sets identical), all inon-call/integration/alert-integration/alert-sources/*.docs.jsonor path changes, so no redirects are needed.Held (needs a decision before documenting)
ai-sre/im.mdxchat_settings-only turn that fixes a chat's team scope / pinned environment in natural language) is behinddeploy.aiSreNlSettings, which the code documents asDefault false: enabling this is a deliberate rollout decision; no console or CLI entry invokes it. Flag off ⇒ behaviour is exactly what the docs already say. Do not write it until the flag is on for customers.fc-event config/config.go:117-122;fc-event etc/deploy.yml:14is the dev/test file (localhost endpoints);fc-saas-web pages/IntegrationCenter/detail/Source/IM/components/AISRESettings.tsxrenders no control for itplatform/quickstart.mdx(new)Skipped
/ambientlark.mdxandslack.mdxare already fixed by #1129; 钉钉 / 企业微信 do not render the off-by-default ambient switch, andmicrosoft-teams.mdxdoes not make the claimescalate-rule-reorderfc-saas-rum pages/SessionsExplorermountsAISREPanelWrapper+AiSreDock.tsx), so the surface is documented from the RUM side insteadrum/error-tracking/error-reporting/ios.mdxcmd/engine/controller/event/error.go→logic/issue/group.go); dSYM symbolication is a read-path enrichment only (sole caller ofProcessor.Enrichiscmd/server/controller/sourcemap/enrich.go:49). Uploading dSYM changes how the stack reads, not the fingerprint. The reader-visible half (an unresolved frame is keyed image + offset, stable within one build) is covered by f011 on the aggregation page.Non-findings checked and dropped deliberately:
monit-webapiexecution-history storage refactor (sameevent_name, fields and query; console limits live infc-saas-monitconstants and still match the docs);fc-eventMongo→PG dual-store/shadow-guard work (internal; the only reader-facing changes are f015–f017);fc-rumcache/interval/workload-group plumbing and session-stat recompute (no documented freshness/granularity/quota claim);go-flashduty/flashduty-cligenerated OpenAPI files (owned by the api-review automation);fc-safariactor/inflight/refactor internals.Cross-repo follow-ups (flashduty-website)
content/changelog/): no entry for the two RUM releases in this window. Latest entry is2026-10-19-341207; add a dated pair covering (1) RUM Explorer query box now docks an AI SRE conversation and (2) a custom dashboard belongs to one application. Same facts as the docs changelog entry added in this PR —zh/changelog/changelog.mdx,<Update label="2026-10-25">.Mapping warnings
fc-foundation-app:mapping.yamladdresses the frontend packages assrc/Packages/<pkg>/..., which does not exist on disk in a standalone clone — analysed fromfc-saas-rum/ai-sre-web/fc-saas-web(repo root == package root). Still unfixed on the skill side.derivative_surfaces.comparison_pagepoints atzh|en/on-call/quickstart/comparison.mdx, which does not exist (the comparison pages arezh|en/on-call/comparison/vs-pagerduty.mdxandvs-opsgenie.mdx) — the automated comparison pass is silently skipped every round; this round's comparison edit (f016) was found by the on-call batch, not by that pass.mcp-server/terraformmoduledocs_pathare directories that do not exist (developer/mcp-server/,developer/terraform/); the real files arezh|en/developer/mcp-server.mdxandterraform.mdx, so those modules are never cross-referenced automatically.Notes for reviewers
zh/rum/explorer/data-query.mdxis the biggest rewrite: the page was restructured into 用 AI 查询 → 用 AI SRE 查询和分析 / 基础自然语言查询, keeping every existing syntax section below untouched.api-reference/**) is untouched:turn_in_flightand RUM dashboardapplication_idreach the OpenAPI specs through the api-review PR docs(api-reference): daily api-review 2026-10-26 — dashboard application_id, session turn_in_flight #1132, not through this PR.release/explorer-ai-queryandfeat/rum-dashboard-per-appmerged in fc-saas-rum; adjust the label if the release actually ships on another date.